Skip to content

docs(javascript): Change default value for maxValueLength #15349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2025
Merged

docs(javascript): Change default value for maxValueLength #15349

merged 1 commit into from
Oct 31, 2025

Conversation

@s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Oct 30, 2025

DESCRIBE YOUR PR

PR getsentry/sentry-javascript#18043 removed the default value of maxValueLength

part of getsentry/sentry-javascript#17389

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Oct 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Oct 30, 2025 11:39am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Oct 30, 2025 11:39am

@s1gr1d s1gr1d requested review from JPeer264 and Lms24 October 30, 2025 11:17
@codecov
Copy link

codecov bot commented Oct 30, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 13.03MB -9 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/qLdSYFUk8FPWj-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/qLdSYFUk8FPWj-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/x1jqul0SZumtD3sP4RvL0/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/x1jqul0SZumtD3sP4RvL0/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@s1gr1d s1gr1d merged commit 2f5ca7c into master Oct 31, 2025
13 checks passed
@s1gr1d s1gr1d deleted the sig/maxValueLength-newDefault branch October 31, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@JPeer264 JPeer264 JPeer264 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@s1gr1d @Lms24 @JPeer264